Implement Gloas withdrawals and refactor by michaelsproul · Pull Request #8692 · sigp/lighthouse

michaelsproul · 2026-01-22T04:27:52Z

This PR implements the Gloas logic for withdrawals and refactors the Capella/Electra logic to match the refactored spec. There should be no consensus changes for the versions prior to Gloas (just refactoring).

michaelsproul · 2026-01-22T04:28:19Z

This is passing the Gloas spec tests, but there's still some more polish I'd like to apply before merging.

michaelsproul · 2026-01-28T00:44:15Z

-    payload: Payload::Ref<'_>,
-    spec: &ChainSpec,
-) -> Result<(), BlockProcessingError> {
-    if state.fork_name_unchecked().capella_enabled() {


I've moved this check up to process_block/per_block_processing so that this function doesn't just no-op in case Capella is disabled. We should not be calling process_withdrawals prior to Capella, that is a serious error.

michaelsproul · 2026-01-28T02:06:55Z

Ready for review!

mergify · 2026-01-28T05:29:26Z

Some required checks have failed. Could you please take a look @michaelsproul? 🙏

eserilev

Feel free to take it or leave it with the nits

michaelsproul · 2026-01-29T04:35:24Z

Gonna avoid linking to the specs because I find these links always go stale and become useless. I think we could say "equivalent to X in the spec" on each function, but that should already kind of be implied.

michaelsproul · 2026-01-29T05:37:58Z

Ready for re-review. There are quite a lot of TODOs, but these are mostly reminders for us to make changes at the next spec release.

eserilev

nice, LGTM!

Do we wait until after the 8.1 release to merge this?

eserilev · 2026-01-31T06:29:27Z

Sounds like alpha.2 is being released early next week. Might make sense to wait on that and make some of the TODO changes before merging

michaelsproul · 2026-02-01T22:25:27Z

I wouldn't mind just merging this now seeing as it's ready, and then a small PR for alpha.2

mergify · 2026-02-03T03:48:27Z

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 1f4a43e

This pull request spent 1 hour 29 minutes 8 seconds in the queue, including 1 hour 27 minutes 8 seconds running CI.
The checks were run on draft #8732.

Required conditions to merge

check-success=local-testnet-success
check-success=test-suite-success

Reason

The merge conditions cannot be satisfied due to failing checks

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

jimmygchen · 2026-02-03T07:04:30Z

@mergify requeue

mergify · 2026-02-03T07:04:46Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2026-02-03T07:05:12Z

Merge Queue Status

✅ The pull request has been merged at 1f4a43e

This pull request spent 31 minutes 11 seconds in the queue, including 29 minutes 47 seconds running CI.
The checks were run on draft #8736.

Required conditions to merge

check-success=local-testnet-success
check-success=test-suite-success

Co-Authored-By: Michael Sproul <michael@sigmaprime.io> Co-Authored-By: Michael Sproul <michaelsproul@users.noreply.github.com>

Implement Gloas withdrawals and refactor

c9bdacd

michaelsproul added work-in-progress PR is a work-in-progress consensus An issue/PR that touches consensus code, such as state_processing or block verification. gloas labels Jan 22, 2026

michaelsproul added 4 commits January 27, 2026 14:47

Clippy

b069167

Small refactor

0fa29cc

Resolve TODO

5838a32

Prevent withdrawals being processed before Capella

c46b93c

michaelsproul commented Jan 28, 2026

View reviewed changes

michaelsproul added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jan 28, 2026

michaelsproul commented Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs Outdated

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

michaelsproul added 2 commits January 28, 2026 16:04

Add ExpectedWithdrawals type for improved safety

091bf2b

Add note about future spec update

5ee2cac

mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 28, 2026

Merge branch 'unstable' into gloas-withdrawals

d7ac508

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs Outdated

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

eserilev reviewed Jan 28, 2026

View reviewed changes

Comment thread consensus/state_processing/src/per_block_processing/withdrawals.rs

eserilev reviewed Jan 28, 2026

View reviewed changes

Use limits from v1.7.0-alpha.1 consistently with notes to update later

1f4a43e

michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jan 29, 2026

jimmygchen mentioned this pull request Jan 29, 2026

Gloas devnet planning #8680

Open

40 tasks

eserilev approved these changes Jan 29, 2026

View reviewed changes

michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 3, 2026

mergify Bot added the queued label Feb 3, 2026

mergify Bot added a commit that referenced this pull request Feb 3, 2026

Merge of #8692

70e294c

mergify Bot mentioned this pull request Feb 3, 2026

merge queue: embarking unstable (99e957a) and #8692 together #8732

Closed

6 tasks

mergify Bot added a commit that referenced this pull request Feb 3, 2026

Merge of #8692

3e6c902

mergify Bot added a commit that referenced this pull request Feb 3, 2026

Merge of #8692

ea78102

mergify Bot mentioned this pull request Feb 3, 2026

merge queue: embarking unstable (99e957a), #8692 and #8717 together #8733

Closed

6 tasks

mergify Bot added dequeued and removed queued labels Feb 3, 2026

mergify Bot added queued and removed dequeued labels Feb 3, 2026

mergify Bot added a commit that referenced this pull request Feb 3, 2026

Merge of #8692

88b11f4

mergify Bot mentioned this pull request Feb 3, 2026

merge queue: embarking unstable (ed7354d) and #8692 together #8736

Closed

6 tasks

mergify Bot merged commit d42327b into unstable Feb 3, 2026
36 checks passed

mergify Bot deleted the gloas-withdrawals branch February 3, 2026 07:36

mergify Bot removed the queued label Feb 3, 2026

Conversation

michaelsproul commented Jan 22, 2026

Uh oh!

michaelsproul commented Jan 22, 2026

Uh oh!

michaelsproul Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

michaelsproul commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify Bot commented Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eserilev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaelsproul commented Jan 29, 2026

Uh oh!

michaelsproul commented Jan 29, 2026

Uh oh!

eserilev left a comment

Choose a reason for hiding this comment

Uh oh!

eserilev commented Jan 31, 2026

Uh oh!

michaelsproul commented Feb 1, 2026

Uh oh!

mergify Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

jimmygchen commented Feb 3, 2026

Uh oh!

mergify Bot commented Feb 3, 2026

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mergify Bot commented Feb 3, 2026 •

edited

Loading

mergify Bot commented Feb 3, 2026 •

edited

Loading